Enhancement/9332 siwg module #9404

eugene-manuilov · 2024-09-24T10:35:05Z

Summary

Addresses issue:

Scaffold Sign in With Google Module #9332

Relevant technical choices

PR Author Checklist

My code is tested and passes existing unit tests.
My code has an appropriate set of unit tests which all pass.
My code is backward-compatible with WordPress 5.2 and PHP 7.4.
My code follows the WordPress coding standards.
My code has proper inline documentation.
I have added a QA Brief on the issue linked above.
I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

Run the code.
Ensure the acceptance criteria are satisfied.
Reassess the implementation with the IB.
Ensure no unrelated changes are included.
Ensure CI checks pass.
Check Storybook where applicable.
Ensure there is a QA Brief.
Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

Ensure the PR has the correct target branch.
Double-check that the PR is okay to be merged.
Ensure the corresponding issue has a ZenHub release assigned.
Add a changelog message to the issue.

…iwg-module.

…Beta badge.

…iwg-module.

github-actions · 2024-09-24T10:41:38Z

Build files for 0374c5e have been deleted.

github-actions · 2024-09-24T10:43:55Z

Size Change: -14.7 kB (-0.79%)

Total Size: 1.84 MB

Filename	Size	Change
`./dist/assets/js/31-********************.js`	0 B	-2.76 kB (removed)	🏆
`./dist/assets/js/32-********************.js`	2.76 kB	+503 B (+22.32%)	🚨
`./dist/assets/js/33-********************.js`	2.25 kB	-1.39 kB (-38.14%)	🎉
`./dist/assets/js/34-********************.js`	3.64 kB	+2.71 kB (+289.73%)	🆘
`./dist/assets/js/35-********************.js`	935 B	+43 B (+4.82%)	🔍
`./dist/assets/js/36-********************.js`	891 B	-2.23 kB (-71.41%)	🏆
`./dist/assets/js/googlesitekit-activation-********************.js`	23.9 kB	-17 B (-0.07%)
`./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js`	70.2 kB	-2.25 kB (-3.11%)
`./dist/assets/js/googlesitekit-adminbar-********************.js`	34.6 kB	+26 B (+0.08%)
`./dist/assets/js/googlesitekit-api-********************.js`	9.99 kB	+22 B (+0.22%)
`./dist/assets/js/googlesitekit-components-gm2-********************.js`	5.96 kB	+1 B (+0.02%)
`./dist/assets/js/googlesitekit-components-gm3-********************.js`	10.1 kB	-2 B (-0.02%)
`./dist/assets/js/googlesitekit-data-********************.js`	2.37 kB	-2 B (-0.08%)
`./dist/assets/js/googlesitekit-datastore-forms-********************.js`	8.95 kB	+1 B (+0.01%)
`./dist/assets/js/googlesitekit-datastore-location-********************.js`	2.08 kB	-1 B (-0.05%)
`./dist/assets/js/googlesitekit-datastore-site-********************.js`	20.4 kB	-5 B (-0.02%)
`./dist/assets/js/googlesitekit-datastore-ui-********************.js`	9.93 kB	+9 B (+0.09%)
`./dist/assets/js/googlesitekit-datastore-user-********************.js`	26.3 kB	+20 B (+0.08%)
`./dist/assets/js/googlesitekit-entity-dashboard-********************.js`	81.6 kB	-1.81 kB (-2.17%)
`./dist/assets/js/googlesitekit-main-dashboard-********************.js`	155 kB	-2.5 kB (-1.59%)
`./dist/assets/js/googlesitekit-modules-********************.js`	22 kB	-145 B (-0.66%)
`./dist/assets/js/googlesitekit-modules-ads-********************.js`	32.8 kB	+84 B (+0.26%)
`./dist/assets/js/googlesitekit-modules-adsense-********************.js`	123 kB	-2.12 kB (-1.69%)
`./dist/assets/js/googlesitekit-modules-analytics-4-********************.js`	173 kB	+644 B (+0.37%)
`./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js`	22.5 kB	-23 B (-0.1%)
`./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js`	21.9 kB	-10 B (-0.05%)
`./dist/assets/js/googlesitekit-modules-search-console-********************.js`	59 kB	+157 B (+0.27%)
`./dist/assets/js/googlesitekit-modules-tagmanager-********************.js`	32 kB	-16 B (-0.05%)
`./dist/assets/js/googlesitekit-notifications-********************.js`	22.4 kB	+3.78 kB (+20.33%)	🚨
`./dist/assets/js/googlesitekit-settings-********************.js`	125 kB	-4.07 kB (-3.15%)
`./dist/assets/js/googlesitekit-splash-********************.js`	86.3 kB	-4.22 kB (-4.66%)	✅
`./dist/assets/js/googlesitekit-user-input-********************.js`	60.8 kB	-3.52 kB (-5.47%)	✅
`./dist/assets/js/googlesitekit-vendor-********************.js`	321 kB	+53 B (+0.02%)
`./dist/assets/js/googlesitekit-widgets-********************.js`	89 kB	+173 B (+0.19%)
`./dist/assets/js/googlesitekit-wp-dashboard-********************.js`	62.1 kB	+46 B (+0.07%)
`./dist/assets/js/runtime-********************.js`	1.3 kB	-2 B (-0.15%)
`./dist/assets/js/37-********************.js`	3.12 kB	+3.12 kB (new file)	🆕
`./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js`	1.01 kB	+1.01 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size
`./dist/assets/css/googlesitekit-admin-css-********************.min.css`	58 kB
`./dist/assets/css/googlesitekit-adminbar-css-********************.min.css`	11.8 kB
`./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css`	846 B
`./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css`	8.2 kB
`./dist/assets/js/analytics-advanced-tracking-********************.js`	901 B
`./dist/assets/js/googlesitekit-consent-mode-********************.js`	25.6 kB
`./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js`	646 B
`./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js`	624 B
`./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js`	630 B
`./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js`	712 B
`./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js`	675 B
`./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js`	634 B
`./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js`	657 B
`./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js`	633 B
`./dist/assets/js/googlesitekit-i18n-********************.js`	3.93 kB
`./dist/assets/js/googlesitekit-polyfills-********************.js`	377 B

_{compressed-size-action}

zutigrm

Thanks @eugene-manuilov Looks good, I just left one tiny comment

zutigrm · 2024-09-25T12:22:58Z

includes/Modules/Sign_In_With_Google.php

+	 * Sets up the module's assets to register.
+	 *
+	 * @since 1.122.0
+	 * @since 1.126.0 Added PAX assets.


Seems this was missed, should be n.e.x.t

yeah, good catch. Thanks, fixed.

…iwg-module.

zutigrm

Thanks @eugene-manuilov, nice one. LGTM

tofumatt

Looks good, just one tiny string tweak that I'll commit, then merge 👍🏻

assets/js/googlesitekit/modules/datastore/__fixtures__/list.json

tests/phpunit/integration/Modules/Sign_In_With_GoogleTest.php

includes/Modules/Sign_In_With_Google.php

eugene-manuilov added 6 commits September 23, 2024 17:05

Add the new module class.

c60a12a

Merge remote-tracking branch 'origin/develop' into enhancement/9332-s…

f1e4943

…iwg-module.

Register the new module in the modules class.

13bbf59

Update the module class to implement deactivation and settings.

92de284

Add basic module script and update setting components to display the …

7d682e8

…Beta badge.

Merge remote-tracking branch 'origin/develop' into enhancement/9332-s…

17b5ad8

…iwg-module.

eugene-manuilov added 3 commits September 24, 2024 14:10

Update vrt images.

acb4760

Implement phpunit tests.

1e72892

Fix formatting issues.

145b63c

zutigrm requested changes Sep 25, 2024

View reviewed changes

eugene-manuilov added 2 commits September 25, 2024 16:26

Merge remote-tracking branch 'origin/develop' into enhancement/9332-s…

acbbcd5

…iwg-module.

Update the @SInCE tag to have the n.e.x.t value.

4b3211b

zutigrm approved these changes Sep 25, 2024

View reviewed changes

tofumatt approved these changes Sep 26, 2024

View reviewed changes

assets/js/googlesitekit/modules/datastore/__fixtures__/list.json Outdated Show resolved Hide resolved

tests/phpunit/integration/Modules/Sign_In_With_GoogleTest.php Outdated Show resolved Hide resolved

includes/Modules/Sign_In_With_Google.php Outdated Show resolved Hide resolved

tofumatt added 3 commits September 26, 2024 22:50

Update i18n string.

1798c56

Update i18n string.

24dcb98

Update i18n string.

0374c5e

tofumatt merged commit 2dfeb93 into develop Sep 26, 2024
22 of 25 checks passed

tofumatt deleted the enhancement/9332-siwg-module branch September 26, 2024 22:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancement/9332 siwg module #9404

Enhancement/9332 siwg module #9404

eugene-manuilov commented Sep 24, 2024

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

zutigrm left a comment

zutigrm Sep 25, 2024

eugene-manuilov Sep 25, 2024

zutigrm left a comment

tofumatt left a comment

Enhancement/9332 siwg module #9404

Enhancement/9332 siwg module #9404

Conversation

eugene-manuilov commented Sep 24, 2024

Summary

Relevant technical choices

PR Author Checklist

Code Reviewer Checklist

Merge Reviewer Checklist

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

zutigrm left a comment

Choose a reason for hiding this comment

zutigrm Sep 25, 2024

Choose a reason for hiding this comment

eugene-manuilov Sep 25, 2024

Choose a reason for hiding this comment

zutigrm left a comment

Choose a reason for hiding this comment

tofumatt left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading