Fix link for RRM module homepage. #9165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for a1b6893 have been deleted. |
tofumatt
requested changes
Aug 7, 2024
| @@ -240,7 +240,7 @@ protected function setup_info() { | |||
| 'name' => _x( 'Reader Revenue Manager', 'Service name', 'google-site-kit' ), | |||
| 'description' => __( 'Reader Revenue Manager helps publishers grow, retain, and engage their audiences, creating new revenue opportunities', 'google-site-kit' ), | |||
| 'order' => 5, | |||
| 'homepage' => __( 'https://readerrevenue.withgoogle.com/', 'google-site-kit' ), | |||
| 'homepage' => __( 'https://publishercenter.google.com', 'google-site-kit' ), | |||
There was a problem hiding this comment.
Why is this URL localised? 🤔
We can't expect (community) localisers to know the right URL to send users to, so let's remove this.
Suggested change
| 'homepage' => __( 'https://publishercenter.google.com', 'google-site-kit' ), | |
| 'homepage' => 'https://publishercenter.google.com', |
There was a problem hiding this comment.
This is actually existent in all modules. Should we maybe create an issue to remove all of them as well?
There was a problem hiding this comment.
As this is a very small change, I've made this myself. I've also opened #9175 to do this for other modules.
tofumatt
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist