Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace __experimentalResolveSelect with resolveSelect. #8967

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

techanvil
Copy link
Collaborator

@techanvil techanvil commented Jul 4, 2024

Summary

This is a followup to #8891, replacing calls to __experimentalResolveSelect() which were added after develop was last merged into that PR's branch.

Addresses issue:

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Jul 4, 2024

Build files for 56ec1a7 have been deleted.

Copy link
Collaborator

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested out locally, works for me.

I added a commit updating an import that looks like it was missed after #8769.

@techanvil
Copy link
Collaborator Author

Thanks @tofumatt, and good spot!

@tofumatt tofumatt merged commit 12e537d into develop Jul 4, 2024
19 of 21 checks passed
@tofumatt tofumatt deleted the infra/8826-followup-fix-resolve-selects branch July 4, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants