Validate have settings change alignment #8927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 689cae9 have been deleted. |
|
Size Change: -152 B (-0.01%) Total Size: 1.55 MB
ℹ️ View Unchanged
|
tofumatt
requested changes
Jun 25, 2024
Comment on lines
-281
to
-294
| /** | ||
| * Indicates whether the current settings have changed from what is saved. | ||
| * | ||
| * @since 1.6.0 | ||
| * @since 1.77.0 Added ability to filter settings using `keys` argument. | ||
| * @since 1.129.0 Changed the approach to use validateHaveSettingsChanged callback. | ||
| * | ||
| * @param {Object} state Data store's state. | ||
| * @param {Array|null} keys Settings keys to check; if not provided, all settings are checked. | ||
| * @return {boolean} True if the settings have changed, false otherwise. |
There was a problem hiding this comment.
Why remove the doc string for the selector? Let's keep it around (and update its documentation if needed, I'd think it would be since it's changed a bit now).
There was a problem hiding this comment.
I removed it since we don't have inline docs in other places for this kind of selectors, but yeah you are right, it makes more sense to keep it since we already have it
| expect( validateHaveSettingsChanged ).toHaveBeenCalled(); | ||
| } ); | ||
| } ); | ||
|
|
There was a problem hiding this comment.
Let's add tests to ensure the "safe" selector (haveSettingsChanged) never throws an exception when __dangerousHaveSettingsChanged would throw.
|
@tofumatt Thanks, PR updated |
tofumatt
deleted the
enhancement/8904-validate-have-settings-change-alignment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
validateHaveSettingsChangedShould Be Updated To Align With Existing Semantic Convention #8904PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist