Add reusable Widget area, New badge feature. #8737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbowler
changed the base branch from
develop
to
enhance/#8138-audience-widget-area
benbowler
changed the base branch from
enhance/#8138-audience-widget-area
to
develop
benbowler
changed the title
|
Waiting on #8138 to be merged then this one can be updated with develop and sent for review. |
|
Build files for e99a2ae have been deleted. |
|
Size Change: +989 B (+0.07%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
benbowler
force-pushed
the
enhancement/8169-widget-area-new-badges
branch
from
99f453b
to
56f49f0
Compare
|
The failing test |
eugene-manuilov
approved these changes
May 28, 2024
tofumatt
reviewed
Jun 20, 2024
| @@ -49,6 +49,9 @@ import WidgetCellWrapper from './WidgetCellWrapper'; | |||
| import useViewOnly from '../../../hooks/useViewOnly'; | |||
| import { CORE_USER } from '../../datastore/user/constants'; | |||
| import useLatestIntersection from '../../../hooks/useLatestIntersection'; | |||
| import NewBadge from '../../../components/NewBadge'; | |||
| import { WEEK_IN_SECONDS } from '../../../util'; | |||
| import { useDispatch } from '@wordpress/data'; | |||
There was a problem hiding this comment.
Just caught that this was used 😅
It won't cause any errors, but we try to import from googlesitekit-data instead. Maybe we should add an ESLint rule about this; I know it autocompletes in VSCode a lot. I'll see if I can improve the suggestions in #8769. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
Implemented as in IB.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist