This repository has been archived by the owner on Feb 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellhancox
suggested changes
May 31, 2024
pmarkowsky
reviewed
May 31, 2024
katmayb
reviewed
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions enclosed, hope this is helpful!
pmarkowsky
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Noticed one redundant sentence.
ddc4090
to
08845eb
Compare
Only some of the comments are included in this first commit. Co-authored-by: Kathryn May <[email protected]> Co-authored-by: Russell Hancox <[email protected]>
Adding some more suggestions. Still more to go through. Co-authored-by: Kathryn May <[email protected]> Co-authored-by: Russell Hancox <[email protected]>
More commits from reviewers Co-authored-by: Kathryn May <[email protected]> Co-authored-by: Russell Hancox <[email protected]> Co-authored-by: Pete Markowsky <[email protected]>
More PR suggestions Co-authored-by: Pete Markowsky <[email protected]> Co-authored-by: Kathryn May <[email protected]>
Co-authored-by: Pete Markowsky <[email protected]>
08845eb
to
070afe9
Compare
russellhancox
approved these changes
Jun 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins a major overhaul to Santa docs, making them current with the current state of the project.
Due to size, this PR does not attempt to update all docs at once in hopes of eliciting better reviews.