This repository has been archived by the owner on Feb 5, 2025. It is now read-only.
lint.sh set -e #1338
Merged
lint.sh set -e #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellhancox
previously approved these changes
May 6, 2024
|
Switched to using pyink for linting and formatting python code. Pylint doesn't format. Black is apparently the new hottness, google forked it (pyink) to follow the google style a bit more closely. |
russellhancox
approved these changes
May 6, 2024
mlw
approved these changes
May 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lint.sh runs are not reporting as failing, when they are in fact failing.
This pull configures lint.sh with set -e to cause failures to be noticed.
Also Testing/fix.sh has been run to green the lint.sh job.