Fix jump target in 3.12 if there are CACHE entries #1669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/649613623
branch
from
0b5e297
to
33d3848
Compare
copybara-service
bot
force-pushed
the
cl/649613623
branch
from
33d3848
to
e5ea640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix jump target in 3.12 if there are CACHE entries
Python 3.12 made the following changes to relative jumps (quoting https://docs.python.org/3.12/library/dis.html):
The number of CACHE entries is fixed per opcode. E.g. in 3.12 the LOAD_GLOBAL opcode is always followed by 4 CACHE entries. This change adds a mapping Python version & opcode and the number of CACHE entries and adjusts the jump target (op.argval) accordingly.