Skip to content

use ninja importability to determine python-ninja usability #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ngam wants to merge 2 commits into from
Closed

use ninja importability to determine python-ninja usability #1378

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53db931
fix ninja importability when python-ninja isn't available
ngam Feb 22, 2023
982d2df
shorten if clause
ngam Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pytype/tools/analyze_project/pytype_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"""Use pytype to analyze and infer types for an entire project."""

import importlib
import collections
import itertools
import logging
Expand Down Expand Up @@ -46,7 +47,8 @@ def _get_executable(binary, module=None):
path_utils.abspath(path_utils.dirname(custom_bin)),
'pytype-single')
])
if sys.executable is not None:
importable = importlib.util.find_spec(module or binary)
if sys.executable is not None and importable:
return [sys.executable, '-m', module or binary]
else:
return [binary]
Expand Down