py::arg and py::arg_v member function chaining fixes
#30155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 28, 2024 23:49
```
/__w/pybind11clif/pybind11clif/tests/test_return_value_policy_pack.cpp:447:73: error: braces around scalar initializer [-Werror,-Wbraced-scalar-init]
447 | py::arg("cb").noconvert().policies(py::return_value_policy_pack({rvpb})),
| ^~~~~~
```
rwgk
pushed a commit
to google/clif
that referenced
this pull request
Sep 6, 2024
This CL was used in a PyCLIF-pybind11 TGP (cl/667456010, 2024-08-26):
http://tap/OCL:667456010:BASE:667610796:1724689781533:d2626456:
```
571 Failing Targets
147 Broken Targets
```
For this to work, a pybind11clif fix is needed (merged already):
* google/pybind11clif#30155
See also: https://b.corp.google.com/issues/287289622#comment75
PiperOrigin-RevId: 668995414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing chaining member function for derived types. Add unit tests.
Fixes transferred from cl/627122374 (originally 2024-04-22).
Suggested changelog entry: