Add missing test_descr_src_loc in CMakeLists.txt
#30137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 20, 2024 17:26
…RE_BACKWARD_COMPATIBILITY)`
…g `test_descr_src_loc` in tests/CMakeLists.txt masked that `src_loc` is not reliable.
rwgk
changed the title
test_descr_src_loc to CMakeLists.txttest_descr_src_loc in CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes trivial long-standing oversight (noticed while working on pybind/pybind11#5255).
The test always ran in the Google-internal system, but not in GitHub Actions.
Suggested changelog entry: