Emit imports in sorted order #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I mostly saw this affecting the files in |
kevmoo
approved these changes
Nov 28, 2022
kevmoo
reviewed
Nov 28, 2022
| /// A utility class to generate a set of imports. The imports will be grouped | ||
| /// by kind (`dart:` imports, `package:` imports, ...) and sorted lexically | ||
| /// within the groups. | ||
| class ImportWriter { |
There was a problem hiding this comment.
pkg:code_builder "just does this". Hrm...
osa1
added a commit
that referenced
this pull request
May 30, 2023
- Bring unnecessary_import back. (was removed with #778) - Generate unused_import in grpc files as well. - Don't generate return_of_invalid_type: this lint seems to be removed. (The first two issues were found in cl/535141580)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #771 - ensure that the imports in the generated code are in lexical order.
ImportWriterclassImportWriteruse regular dart import conventions (dart: first, package: second, path imports third, and lexically ordered within the groups)Done as separate commits for easier review.