Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant reserved names #679

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Conversation

osa1
Copy link
Member

@osa1 osa1 commented Jun 16, 2022

This reverts commit c35d787.

These reserved names are no longer reserved (see 146b186, b96dc21), but
we kept them to avoid breaking backwards compatibility.

Removing them now for the next major version bump.

Closes #637

This reverts commit c35d787.

These reserved names are no longer reserved (see 146b186, b96dc21), but
we kept them to avoid breaking backwards compatibility.

Removing them now for the next major version bump.

Closes google#637
@osa1 osa1 requested a review from sigurdm June 16, 2022 08:52
Copy link
Collaborator

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osa1 osa1 merged commit 8137057 into google:master Jun 16, 2022
@osa1 osa1 deleted the update_reserved_names branch June 16, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert c35d7877 (redundant reserved names) before next major release
2 participants