Minor fix in query_bench set_nested_value benchmark: #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rebuild` shallow clones the message and returns an updated message, so return value should be used. Thanks to @sigurdm for noticing this.
osa1
added a commit
to osa1/protobuf.dart
that referenced
this pull request
Apr 25, 2022
This catches issues like google#630 where we forgot to use return value of `rebuild`. Since `rebuild` does not update in-place, forgetting to use the return value is often a bug. This adds `meta` as a dependency but it should not affect generated code. We may also want to use `meta` in the future for things like: - Annotating `GeneratedMessage` methods that are supposed to be used by the generated code with `@protected`. - Annotating generated message classes with `@sealed`. This help with maintaining backwards compatibility when adding new members to generated messages or to `GeneratedMessage`.
osa1
added a commit
to osa1/protobuf.dart
that referenced
this pull request
Apr 25, 2022
This catches issues like google#630 where we forgot to use return value of `rebuild`. Since `rebuild` does not update in-place, not using the return value is often a bug. This adds `meta` as a dependency but it should not affect generated code. We may also want to use `meta` in the future for things like: - Annotating `GeneratedMessage` methods that are supposed to be used by the generated code with `@protected`. - Annotating generated message classes with `@sealed`. This help with maintaining backwards compatibility when adding new members to generated messages or to `GeneratedMessage`.
osa1
added a commit
that referenced
this pull request
May 6, 2022
This catches issues like #630 where we forgot to use return value of `rebuild`. Since `rebuild` does not update in-place, not using the return value is often a bug. This adds `meta` as a dependency but it should not affect generated code. We may also want to use `meta` in the future for things like: - Annotating `GeneratedMessage` methods that are supposed to be used by the generated code with `@protected`. - Annotating generated message classes with `@sealed`. This help with maintaining backwards compatibility when adding new members to generated messages or to `GeneratedMessage`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebuildshallow clones the message and returns an updated message, soreturn value should be used.
Thanks to @sigurdm for noticing this.