Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc_plugin README fixes and tweaks: #617

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Conversation

osa1
Copy link
Member

@osa1 osa1 commented Apr 20, 2022

  • Fix proto syntax

  • Add syntax = "proto3" in proto examples. proto3 is used instead of
    proto3 is newer. Removed optionals.

  • Minor rewording

Closes #208

- Fix proto syntax

- Add `syntax = "proto3"` in proto files. proto3 is used instead of
  proto2 as the files are valid proto3, and proto3 is newer.

- Minor rewording

Fixes google#208
@osa1 osa1 requested a review from sigurdm April 20, 2022 12:10
protoc_plugin/README.md Outdated Show resolved Hide resolved
@osa1 osa1 merged commit 99bc541 into google:master Apr 22, 2022
@osa1 osa1 deleted the more_readme_tweaks branch April 22, 2022 09:24
osa1 added a commit to osa1/protobuf.dart that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protoc_plugin readme is outdated
2 participants