Correctly combine hash codes for repeated enums. #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing logic in `hashField` is overriding the previously computed hash codes, which could include values from other fields within the message. Any message with a repeated enum field with a (relatively) high tag number will generate a poor hash code which doesn't reflect other fields.
rakudrama
approved these changes
Nov 12, 2021
osa1
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic in
hashFieldis overriding the previously computed hash codes, which could include values from other fields within the message. Any message with a repeated enum field with a (relatively) high tag number will generate a poor hash code which doesn't reflect other fields.