Skip to content

Fix non-proto3 JSON format double decoding #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osa1 merged 3 commits into from
Aug 28, 2025
Merged

Fix non-proto3 JSON format double decoding #1043

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94155ce
Fix non-proto3 JSON format double decoding
osa1 Aug 27, 2025
d177538
Update changelog
osa1 Aug 27, 2025
02f8c9c
Revert CHANGELOG
osa1 Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions protobuf/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@
* Improve performance of `GeneratedMessage.deepCopy`. ([#742])
* Fix unknown enum handling in `GeneratedMessage.mergeFromProto3Json` when
the `ignoreUnknownFields` optional argument is `true`. ([#853])
* Fix decoding doubles in `GeneratedMessage.mergeFromJson` and
`GeneratedMessage.mergeFromJsonMap` with dart2wasm. ([#1043])

[#742]: https://github.com/google/protobuf.dart/pull/742
[#853]: https://github.com/google/protobuf.dart/pull/853
[#1043]: https://github.com/google/protobuf.dart/pull/1043

## 4.2.0

Expand Down
2 changes: 1 addition & 1 deletion protobuf/lib/src/protobuf/json/json_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ Object? _convertRawJsValue(
// Allow quoted values, although we don't emit them.
if (value.isA<JSNumber>()) {
final jsNum = value._as<JSNumber>();
return _Number._isInteger(jsNum) ? jsNum.toDartInt : jsNum.toDartDouble;
return jsNum.toDartDouble;
} else if (value.isA<JSString>()) {
return double.parse(value._as<JSString>().toDart);
}
Expand Down
Loading