Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use GenerateProtoTask as source of output dirs information (3/3) #670

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Do not use GenerateProtoTask as source of output dirs information (3/3) #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
cc4c151
Extract GenerateProtoTask configuration fields to GenerateProtoTaskSpec
rougsig Jan 24, 2023
46acc13
Migrate test project to use temporary spec configuration method
rougsig Jan 24, 2023
e319c64
Specify spec configuration method closure type
rougsig Jan 24, 2023
93ddb7a
Extract GenerateProtoTask querying fields to ProtoVariant
rougsig Jan 25, 2023
415c9be
Migrate test projects to use newer configuration api
rougsig Jan 25, 2023
61747be
Fix GenerateProtoTaskCollection method with closures
rougsig Jan 25, 2023
1a8baea
Fix testProjectBuildTimeProto project
rougsig Jan 25, 2023
07a3bf2
Fix codenarc issues
rougsig Jan 25, 2023
3dbeccd
Fix tests for GenerateProtoTaskCollection
rougsig Jan 25, 2023
5672e23
Fix tests again
rougsig Jan 25, 2023
835935c
Do not use GenerateProtoTask as source of output dirs information
rougsig Jan 25, 2023
4b4d226
Fix codenarc issues
rougsig Jan 25, 2023
8d0e1fd
Do not use project in GenerateProtoTask constructor
rougsig Jan 25, 2023
536b166
Do not use project in any GenerateProtoTask @Input field
rougsig Jan 25, 2023
1d4eac5
Add android task configuration avoidance test
rougsig Jan 27, 2023
e076fa3
Fix codenarc issues
rougsig Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ configurations {
}

dependencies {
compileOnly "com.android.tools.build:gradle:4.1.0"
compileOnly "com.android.tools.build:gradle:4.2.2"
compileOnly "org.jetbrains.kotlin.android:org.jetbrains.kotlin.android.gradle.plugin:1.7.22"

implementation 'com.google.gradle:osdetector-gradle-plugin:1.7.2'
Expand Down
4 changes: 2 additions & 2 deletions examples/exampleKotlinDslProject/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ protobuf {
}
}
generateProtoTasks {
ofSourceSet("main").forEach {
it.plugins {
ofSourceSet("main") {
plugins {
// Apply the "grpc" plugin whose spec is defined above, without
// options. Note the braces cannot be omitted, otherwise the
// plugin will not be added. This is because of the implicit way
Expand Down
2 changes: 1 addition & 1 deletion examples/exampleProject/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ protobuf {
}
}
generateProtoTasks {
ofSourceSet('main').configureEach {
ofSourceSet('main') {
plugins {
// Apply the "grpc" plugin whose spec is defined above, without
// options. Note the braces cannot be omitted, otherwise the
Expand Down
Loading