Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract configuration fields from task to spec class (1/3) #668

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rougsig
Copy link
Collaborator

@rougsig rougsig commented Jan 24, 2023

Background
To prevent eager task configuration for android, we need to know the list of output folders from generate proto task.

Changes
Extract all configuration fields from GenerateProtoTask to one GenerateProtoTaskSpec field.

Test plan
Green pipelines.

@rougsig rougsig requested a review from ejona86 January 24, 2023 21:10
@rougsig
Copy link
Collaborator Author

rougsig commented Jan 24, 2023

note:
small part for fix for #643.

Second Part will be rewrite generateProtoTask {} to use spec directly without task proxy.
Third part will be use extracted values from task as sources for agp/other tasks.

@rougsig rougsig changed the title Extract configuration fields from task to spec class (1/3) Extract configuration fields from task to spec class (1/2) Jan 24, 2023
@rougsig rougsig changed the title Extract configuration fields from task to spec class (1/2) Extract configuration fields from task to spec class (1/3) Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant