Support packaging proto files into android archives(aar)

[bennyhuo]

Support packaging proto files into android archives(aar) and extracting included proto files from android libraries. Tested on android gradle plugin v3.6.3. (#56)

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[bennyhuo]

@googlebot I signed it!

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[voidzcy]

Are you interested in adding tests for covering the usage of consuming an Android library project? (It might be non-trivial as we cannot reuse testProjectBase to construct an Android Library project, would need to write one with the same proto sources but a build_base.gradle for android build)

[bennyhuo]

OK

…

--------------原始邮件-------------- 发件人："Chengyuan Zhang "<[email protected]&gt;; 发送时间：2020年6月29日(星期一) 中午12:59 收件人："google/protobuf-gradle-plugin" <[email protected]&gt;; 抄送："Bennyhuo "<[email protected]&gt;;"Author "<[email protected]&gt;; 主题：Re: [google/protobuf-gradle-plugin] Fix #56. Support packaging proto files into android archives(aar). (#414) ----------------------------------- Are you interested in adding tests for covering the usage of consuming an Android library project? (It might be non-trivial as we cannot reuse testProjectBase to construct an Android Library project, would need to write one with the same proto sources but a build_base.gradle for android build) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[bennyhuo]

I created a project testProjectAndroidLibrary and simply renamed the helloworld.proto to helloAar.proto with the package name to 'io.grpc.helloaarexample'. And add the library as a dependency to testProjectAndroidBase. Check HelloAarActivity.java.

BTW, there is no need to explicitly exclude proto files in packagingOptions. I have handled it in ProtobufPlugin.groovy:237.

[voidzcy]

BTW, there is no need to explicitly exclude proto files in packagingOptions. I have handled it in ProtobufPlugin.groovy:237.

We want to only include proto files in packaging for android libraries, but not for applications. Applications are very sensitive to the apk size, including proto files in apk increases unnecessary bytes.

It looks the default packagingOption does not include **/*.proto. If that true, we don't need that line.

[bennyhuo]

BTW, there is no need to explicitly exclude proto files in packagingOptions. I have handled it in ProtobufPlugin.groovy:237.

We want to only include proto files in packaging for android libraries, but not for applications. Applications are very sensitive to the apk size, including proto files in apk increases unnecessary bytes.

It looks the default packagingOption does not include **/*.proto. If that true, we don't need that line.

The default packaingOption does include proto files. So we should either config that in the project.android.packingOptions in every application project or just make it part of the plugin.

I add these lines to make it default when applied the ProtoBufPlugin, that is to say, if it is a library project, don't exclude **/*.proto, otherwise (it may be an application project or a feature plugin project) exclude all proto files:

        if (!project.android.hasProperty('libraryVariants')) {
          project.android.packagingOptions.exclude("**/*.proto")
        }

We should not include proto files for both apk size and security reasons.

[voidzcy]

Mostly LGTM, with a couple of nits.

Thanks for your contribution.

[voidzcy]

Merging. Thanks for contributing.