Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend coverage of usage with Java and Kotlin plugins to Gradle 6.0 #365

Merged
merged 3 commits into from
Dec 13, 2019

Conversation

eskatos
Copy link
Contributor

@eskatos eskatos commented Dec 12, 2019

This PR extends the existing tests to cover the usage of the Protobuf plugin with the Java and Kotlin plugins with Gradle 6.0.

No changes were required to the Protobuf plugin. The dependency to the Kotlin Gradle Plugin had to be bumped from 1.3.10 to 1.3.20.

for better readability in IDE & test reports

Signed-off-by: Paul Merlin <[email protected]>
This requires bumping the Kotlin Gradle Plugin dependency
from 1.3.10 to 1.3.20

Signed-off-by: Paul Merlin <[email protected]>
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@eskatos
Copy link
Contributor Author

eskatos commented Dec 12, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@zhangkun83 zhangkun83 requested a review from voidzcy December 12, 2019 20:28
Copy link
Collaborator

@voidzcy voidzcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enhancement with @Unroll looks great.

@voidzcy voidzcy merged commit d893ca8 into google:master Dec 13, 2019
@eskatos eskatos deleted the eskatos/gradle6 branch December 13, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants