Do not call variant.javaCompile for android 3.3.0+ to get rid of Android API warning #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangkun83
approved these changes
Jun 18, 2019
|
@zhangkun83 I was trying to enable tests for Android plugin 3.4 and Gradle 5.4. But it seems there were things changed in 3.2 and will cause tests fail at |
|
Do you know an ETA when there will be a 0.9.0 release available with this change? |
|
@kcoppock Since this warning fix isn't a sever bug, we may not have a new release until having other bigger changes. |
|
It's breaking Android builds - can we just do a 0.8.10 for this? |
|
/cc @zhangkun83 |
|
Yeah. 0.8.10 now released! |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #295
I believe this is just something forgotten in #305. Thanks @kcoppock for point this out in #295 (comment).