Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 0.9.0 causes include in sourceSets to be ignored #620

Closed
yu-shiba opened this issue Oct 7, 2022 · 4 comments
Closed

Update to 0.9.0 causes include in sourceSets to be ignored #620

yu-shiba opened this issue Oct 7, 2022 · 4 comments
Assignees
Labels

Comments

@yu-shiba
Copy link

yu-shiba commented Oct 7, 2022

When using 0.9.0 and building a project with sourceSets specified, includes are ignored and the following error occurs

* What went wrong:
Execution failed for task ':generateProto'.
> protoc: stdout: . stderr: [libprotobuf WARNING T:\src\github\protobuf\src\google\protobuf\compiler\parser.cc:562] No syntax specified for the proto file: test.yml. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
  test.yml:1:1: Expected top-level statement (e.g. "message").

Reproduction method

git clone https://github.com/google/protobuf-gradle-plugin.git
cd protobuf-gradle-plugin/examples/exampleProject
sed -i 's/0\.8\.19/0.9.0/' build.gradle
cat << EOS >> build.gradle
sourceSets {
    main {
        proto {
            srcDir('src/main/proto')
        }
    }
}
EOS
echo "foo" > src/main/proto/test.yml
gradle build
rougsig added a commit to rougsig/protobuf-gradle-plugin that referenced this issue Oct 7, 2022
rougsig added a commit to rougsig/protobuf-gradle-plugin that referenced this issue Oct 7, 2022
@rougsig rougsig self-assigned this Oct 7, 2022
@rougsig
Copy link
Collaborator

rougsig commented Oct 7, 2022

Will fix in couple days.

rougsig added a commit to rougsig/protobuf-gradle-plugin that referenced this issue Oct 7, 2022
rougsig added a commit to rougsig/protobuf-gradle-plugin that referenced this issue Oct 7, 2022
rougsig added a commit to rougsig/protobuf-gradle-plugin that referenced this issue Oct 7, 2022
rougsig added a commit to rougsig/protobuf-gradle-plugin that referenced this issue Oct 7, 2022
@ejona86
Copy link
Collaborator

ejona86 commented Oct 8, 2022

Fixed by #621

@ejona86 ejona86 closed this as completed Oct 8, 2022
@ejona86
Copy link
Collaborator

ejona86 commented Oct 8, 2022

0.9.1 is released with the fix for this issue.

@yu-shiba
Copy link
Author

yu-shiba commented Oct 8, 2022

Thank you for handling this matter so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants