-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests failing on workstation when run at HEAD #650
Comments
Perhaps I'm missing a dependency required to make this work -- it's very likely I'm just holding this wrong. |
I could not reproduce the failure from pprof master:HEAD $uname -a $cat /etc/os-release $cd /prj/Go/src/github.com/google/pprof $go version $go env $git branch -a
$git pull $go clean --testcache |
I can't repro this on my personal mac either. I'll try repro it on my work-workstation tomorrow.
|
What tool is used to generate the assembly dump? https://stackoverflow.com/a/46753525/171898 says Looks like Possibly given this is failing on my workstation the problem is a difference between packages shelled out to. |
Anyway maybe we could fix this just by replacing the regex |
I wanted to find what commands are ran while running the test, so I ran execsnoop at the same time as the test:
So the problem is in one of those commands. Running:
And this version outputs
|
Different versions of `objdump` output `call` or `callq`. Both work fine for the purposes of the test. Fixes google#650
Different versions of `objdump` output `call` or `callq`. Both work fine for the purposes of the test. Fixes #650
What version of pprof are you using?
02619b876842e0d0afb5e5580d3a374dad740edb
What operating system and processor architecture are you using?
What did you do?
What did you expect to see?
Tests pass
What did you see instead?
One test fails.
Looks like the test is asserting that it contains
callq.*mapassign
but it only containscall.*mapassign
.The text was updated successfully, but these errors were encountered: