Skip to content

Commit

Permalink
Avoid adding a redundant newline when printing weblistPageClosing (#665)
Browse files Browse the repository at this point in the history
* Replace fmt.Println with fmt.Printf for newline-ending string.

This would otherwise be caught with the improved vet printf
checker (golang/go#30436).

* Replace fmt.Println with fmt.Printf for newline-ending string.

This would otherwise be caught with the improved vet printf
checker (golang/go#30436).

* Avoid adding a redundant newline when printing weblistPageClosing.
  • Loading branch information
zpavlinovic authored Nov 4, 2021
1 parent f410f49 commit f987b9c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion internal/driver/testdata/pprof.cpu.flat.addresses.weblist
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,3 @@ Duration: 10s, Total samples = 1.12s (11.20%)<br>Total: 1.12s</div><h2>line1000<

</body>
</html>

3 changes: 1 addition & 2 deletions internal/report/source_html.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,4 @@ function pprof_toggle_asm(e) {

const weblistPageClosing = `
</body>
</html>
`
</html>`

0 comments on commit f987b9c

Please sign in to comment.