Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: setup workflow to run semantic tests weekly #958

Merged

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented May 1, 2024

Cherry-pick of G-Rath/osv-detector#182


This setups up a dedicated workflow for running the semantic test suite using the latest generated fixtures:

  • every sunday
  • whenever a generator or the workflow is changed
  • via a workflow_dispatch

This helps ensure high confidence in semantic across ecosystems; the workflow also exports the generated files as an artifact which makes it easy to update the committed version of each fixture without requiring the native ecosystem components (i.e. Ruby, Java, R, etc) to be installed.

Note currently this is using v3 of the artifact actions - I'll upgrade to v4 in a follow-up PR, since it will require further work due to them switching to using immutable artifacts.

At some point I'm also keen to explore this for the API side since the logic should be pretty much the same

@G-Rath G-Rath force-pushed the generators/introduce-semantic-workflow branch 2 times, most recently from baa7208 to 5f95a0c Compare May 1, 2024 19:57
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.32%. Comparing base (0753337) to head (856e26a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
- Coverage   65.35%   65.32%   -0.03%     
==========================================
  Files         150      150              
  Lines       12535    12535              
==========================================
- Hits         8192     8189       -3     
- Misses       3883     3885       +2     
- Partials      460      461       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@G-Rath G-Rath force-pushed the generators/introduce-semantic-workflow branch 4 times, most recently from 94c37b0 to 999f335 Compare May 6, 2024 23:15
@G-Rath
Copy link
Collaborator Author

G-Rath commented Jun 11, 2024

Ok so now we have support for Alpine which ideally we should run as part of this, but I found that can take hours when running through docker - for implementing that I did end up compiling a custom binary from the actual C code which was blazingly fast but I'm not sure if there's a way we can easily make that an option?

I'm thinking for now I'll just omit the Alpine generator, and make an issue for adding it + try to explore how we might be able make it faster (such as running the whole generator in a docker container)

@G-Rath G-Rath force-pushed the generators/introduce-semantic-workflow branch from 999f335 to d333f7e Compare June 20, 2024 23:36
@G-Rath G-Rath marked this pull request as ready for review June 20, 2024 23:36
@G-Rath G-Rath requested review from another-rex, cuixq and hogo6002 June 20, 2024 23:36
@G-Rath

This comment was marked as resolved.

@G-Rath G-Rath force-pushed the generators/introduce-semantic-workflow branch from d333f7e to 7205da8 Compare June 27, 2024 01:51
@G-Rath G-Rath force-pushed the generators/introduce-semantic-workflow branch from 7205da8 to 856e26a Compare June 28, 2024 01:30
@another-rex another-rex merged commit b3315a3 into google:main Jun 28, 2024
20 checks passed
@G-Rath G-Rath deleted the generators/introduce-semantic-workflow branch June 28, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants