-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guided Remediation: Add manifest resolution #757
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
+ Coverage 79.67% 79.72% +0.04%
==========================================
Files 89 89
Lines 6145 6145
==========================================
+ Hits 4896 4899 +3
+ Misses 1045 1043 -2
+ Partials 204 203 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's a good way to test this manually before we get automated tests?
Re tests, it would be easiest to run the internal version for now. Check with @michaelkedar on this. |
Yeah, manually testing this as-is would be clumsy - you have to manually fill in the |
Starting to make guided remediation public #352 🎉
This PR has the code used to resolve the dependency graph of a manifest (i.e. a
package.json
) using the deps.dev resolvers and find vulnerabilities within it.Doesn't include the code to actually parse/write
package.json
files - will probably add that in the next PR.Much of this has been reviewed internally already, but I've made some significant changes/refactoring to
dependency_chain.go
and thecomputeVulns()
function inresolve.go
, so please take a more careful look at those.