verify the spdx licenses passed in to the license allowlist #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josieang
commented
Jan 1, 2024
There was a problem hiding this comment.
the prompt for bard "code for reading spdx expressions from https://github.com/spdx/license-list-data/blob/main/json/licenses.json into a file using go generate"
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
==========================================
- Coverage 78.70% 78.17% -0.53%
==========================================
Files 84 85 +1
Lines 6047 6057 +10
==========================================
- Hits 4759 4735 -24
- Misses 1085 1117 +32
- Partials 203 205 +2 ☔ View full report in Codecov by Sentry. |
|
Can you add a test for the unrecognized code path? |
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.