Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for renv.lock #668

Merged
merged 4 commits into from
Nov 27, 2023
Merged

feat: add support for renv.lock #668

merged 4 commits into from
Nov 27, 2023

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Nov 20, 2023

Resolves #642

@G-Rath G-Rath marked this pull request as ready for review November 22, 2023 00:14
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (54d61f3) 78.50% compared to head (1ff1cdd) 78.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
+ Coverage   78.50%   78.60%   +0.10%     
==========================================
  Files          82       83       +1     
  Lines        5890     5918      +28     
==========================================
+ Hits         4624     4652      +28     
  Misses       1068     1068              
  Partials      198      198              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gareth!

@@ -13,6 +13,7 @@ func KnownEcosystems() []Ecosystem {
PipEcosystem,
PubEcosystem,
ConanEcosystem,
CRANEcosystem,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: probably for another PR, but we should look sort this list alphabetically.

@oliverchang oliverchang merged commit e99410e into google:main Nov 27, 2023
@G-Rath G-Rath deleted the support-renv-lockfiles branch December 19, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for scanning renv lockfiles for the R language
3 participants