Skip to content

fix: return error when container image is missing #3083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
another-rex merged 1 commit into from
Sep 14, 2026
Merged

fix: return error when container image is missing #3083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/osvscanner/osvscanner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,10 @@ func DoScan(actions ScannerActions) (models.VulnerabilityResults, error) {
}

func DoContainerScan(actions ScannerActions) (models.VulnerabilityResults, error) {
if actions.Image == "" {
return models.VulnerabilityResults{}, errors.New("container image must be provided")
}

scanResults := results.ScanResults{
ConfigManager: config.Manager{
DefaultConfig: config.Config{},
Expand Down
13 changes: 13 additions & 0 deletions pkg/osvscanner/osvscanner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,19 @@ import (
"github.com/google/osv-scanner/v2/pkg/osvscanner"
)

func TestDoContainerScan_NoImage(t *testing.T) {
t.Parallel()

_, err := osvscanner.DoContainerScan(osvscanner.ScannerActions{})
if err == nil {
t.Fatal("DoContainerScan() error = nil, want an error")
}

if got, want := err.Error(), "container image must be provided"; got != want {
t.Errorf("DoContainerScan() error = %q, want %q", got, want)
}
}

// TestDoScan_LogHandlerOverride tests that the SetLogger override works correctly
//
//nolint:paralleltest // No parallel test since slog.SetDefault sets global behavior
Expand Down
Loading