Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid infinite loops parsing Maven poms with syntax errors #294

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

spencerschrock
Copy link
Contributor

Resolves #293

Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I get for not checking error values 🤦

@oliverchang
Copy link
Collaborator

Thanks @spencerschrock!!

@another-rex another-rex merged commit b76e5ad into google:main Mar 14, 2023
@spencerschrock spencerschrock deleted the bug/maven-lock-loop branch March 14, 2023 01:02
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseMavenLock hangs when parsing some Maven archetypes files
4 participants