Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(osv-query): omit SourceInfo from JSON marshaling #185

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

cmaritan
Copy link
Contributor

@cmaritan cmaritan commented Feb 4, 2023

Resolve #184 (if models.SourceInfo is confirmed to be unneeded!)

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You're right it is not needed, did not know - is an option.

@another-rex another-rex merged commit de9f341 into google:main Feb 5, 2023
cmaritan added a commit to cmaritan/osv-scanner that referenced this pull request Feb 12, 2023
Resolve google#184 (if `models.SourceInfo` is confirmed to be unneeded!)
@cmaritan cmaritan deleted the omit-sourceinfo branch February 20, 2023 23:20
hayleycd pushed a commit that referenced this pull request Mar 9, 2023
Resolve #184 (if `models.SourceInfo` is confirmed to be unneeded!)
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
Resolve google#184 (if `models.SourceInfo` is confirmed to be unneeded!)
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
Resolve google#184 (if `models.SourceInfo` is confirmed to be unneeded!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Is SourceInfo needed in Query to osv.dev?
2 participants