Skip to content

Conversation

@G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Apr 3, 2025

The new major primarily was focused on overhauling the config structure along with introducing the concept of formatters as being different from linters, though it also seems to have super charged staticcheck as that has a number of new findings mainly around being able to remove embedded fields.

For now I have disabled the failing checks and will look to review + tackle them in follow up PRs

Also see the migration guide for details on the changes

@G-Rath G-Rath requested review from another-rex, cuixq and hogo6002 April 3, 2025 20:22
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.18%. Comparing base (d226688) to head (3fc708d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1781   +/-   ##
=======================================
  Coverage   65.18%   65.18%           
=======================================
  Files         164      164           
  Lines       15862    15862           
=======================================
  Hits        10339    10339           
  Misses       4855     4855           
  Partials      668      668           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath
Copy link
Collaborator Author

G-Rath commented Apr 3, 2025

Actually I just realised the "new" staticcheck violations are because v2 does not have "false positives" overrides, so most if not all of these new violations are from these

@G-Rath
Copy link
Collaborator Author

G-Rath commented Apr 4, 2025

The linter check is currently failing due to golangci/golangci-lint#5692

@G-Rath G-Rath force-pushed the linting/upgrade-v2 branch from 73cdcc6 to 422b572 Compare May 20, 2025 03:02
@G-Rath G-Rath force-pushed the linting/upgrade-v2 branch from 422b572 to 3fc708d Compare May 20, 2025 19:18
@another-rex another-rex merged commit 36a890e into google:main May 23, 2025
15 checks passed
@another-rex another-rex deleted the linting/upgrade-v2 branch May 23, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants