Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme usage section #171

Merged
merged 15 commits into from
Feb 2, 2023

Conversation

hayleycd
Copy link
Collaborator

These are some small changes to the usage section of the README, based on conversations with @olivekl.
The goal was to clarify the different options available to the user.

Clarify the options between scanning a directory, specifiying SBOM, and specifying lockfiles.
@google-cla
Copy link

google-cla bot commented Jan 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Gareth Jones <[email protected]>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
hayleycd and others added 2 commits January 27, 2023 14:29
Co-authored-by: Gareth Jones <[email protected]>
Co-authored-by: Gareth Jones <[email protected]>
@hayleycd
Copy link
Collaborator Author

@olivekl wants to review next week. She is also checking on the CLA issue.

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me, just two comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@olivekl olivekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making it clearer how to use the scanner! My comments are only minor nits.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
hayleycd and others added 2 commits February 2, 2023 15:23
Co-authored-by: Rex P <[email protected]>
Co-authored-by: Rex P <[email protected]>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -83,46 +83,43 @@ All releases on the same Major version will be guaranteed to have backward compa

## Usage

OSV-Scanner collects a list of dependencies and versions that are used in your project, before matching this list against the OSV database via the [OSV.dev API](https://osv.dev#use-the-api). To build the list of dependencies, you can point OSV-Scanner at your project directory, or manually pass in the path to individual manifest files.
OSV-scanner parses lockfiles, SBOMs, and git directories to determine your project's open source dependencies. These dependencies are matched against the OSV database via the [OSV.dev API](https://osv.dev#use-the-api) and known vulnerabilities are returned to you in the output.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've stylized this tool as "OSV-Scanner" in many places. Any particular reason to change this to "OSV-scanner" with the lowercasing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. That is me learning the ropes.

README.md Outdated Show resolved Hide resolved
@oliverchang oliverchang merged commit f8eec77 into google:main Feb 2, 2023
@hayleycd hayleycd deleted the update-readme-usage-section branch February 3, 2023 16:35
hayleycd added a commit that referenced this pull request Mar 9, 2023
These are some small changes to the usage section of the README, based on conversations with @olivekl.
The goal was to clarify the different options available to the user.
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
These are some small changes to the usage section of the README, based on conversations with @olivekl.
The goal was to clarify the different options available to the user.
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
These are some small changes to the usage section of the README, based on conversations with @olivekl.
The goal was to clarify the different options available to the user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants