Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: corrected field names in osv scanner results in the JSON doc #1398

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

janniclas
Copy link
Contributor

Corrected JSON field names in the osv-scanner documentation. Previously, one key was incorrectly called sourcePackage and was changed to source.

Closes #1391

Copy link

google-cla bot commented Nov 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@hogo6002 hogo6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (a8b7c34) to head (9b26d09).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
- Coverage   68.96%   68.81%   -0.16%     
==========================================
  Files         185      185              
  Lines       17934    17934              
==========================================
- Hits        12368    12341      -27     
- Misses       4903     4927      +24     
- Partials      663      666       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janniclas
Copy link
Contributor Author

@hogo6002 do I correctly assume that the failing check has nothing to do with my changes so I can consider this done from my side? :)

@another-rex
Copy link
Collaborator

@hogo6002 do I correctly assume that the failing check has nothing to do with my changes so I can consider this done from my side? :)

Yes, this is caused by codecov timing out for some reason, rerunning it now hopefully it'll work this time :)

@hogo6002 hogo6002 merged commit c80f395 into google:main Nov 14, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect field name for "source" in OSV Scanner Results JSON Documentation
4 participants