-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(guided remediation): handle extraneous/missing packages in package-lock.json more leniently #1394
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1394 +/- ##
==========================================
- Coverage 69.02% 68.88% -0.14%
==========================================
Files 185 185
Lines 17869 17950 +81
==========================================
+ Hits 12334 12365 +31
- Misses 4876 4916 +40
- Partials 659 669 +10 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Children map[string]*npmNodeModule // keyed on package name | ||
Deps map[string]string | ||
OptionalDeps map[string]string | ||
DevDeps map[string]string // dev dependencies are also included in Deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain a bit more why we don't need DevDeps
and OptionalDeps
here anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deps
now also contains the dep.Type
, which has whether it's optional or dev (or peer) in it.
Changes two things for package-lock.json parsing: