Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump osv max concurrent requests #1290

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

hogo6002
Copy link
Contributor

@hogo6002 hogo6002 commented Oct 1, 2024

The current maxConcurrentRequests setting is insufficient for container scanning, where one scan may report more than a thousand vulnerabilities. Bump it up to 1000 to fix it.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.53%. Comparing base (a20e520) to head (77c1b15).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1290   +/-   ##
=======================================
  Coverage   68.53%   68.53%           
=======================================
  Files         175      175           
  Lines       16804    16804           
=======================================
  Hits        11516    11516           
  Misses       4661     4661           
  Partials      627      627           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewpollock
Copy link
Contributor

Trying to understand the impact on an end user in a bandwidth-challenged environment...

Does this result in up to 1,000 concurrent separate API requests for individual vulnerabilities?
Or a single batch query for up to 1,000 vulnerabilities?

pkg/osv/osv.go Show resolved Hide resolved
@another-rex
Copy link
Collaborator

Does this result in up to 1,000 concurrent separate API requests for individual vulnerabilities?
Or a single batch query for up to 1,000 vulnerabilities?

The former, 1000 concurrent separate API requests.

@hogo6002
Copy link
Contributor Author

hogo6002 commented Oct 1, 2024

Does this result in up to 1,000 concurrent separate API requests for individual vulnerabilities? Or a single batch query for up to 1,000 vulnerabilities?

It's for the individual vulnerability queries.

@hogo6002 hogo6002 merged commit c080496 into google:main Oct 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants