Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't assume there's always a reason for a package being filtered out #1241

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Sep 11, 2024

Currently if you don't provide a reason for an override the scanner will just output "because: " which looks weird and results in a trailing space in our snapshots which IDEs try to trim.

Since we want to encourage people to provide a reason, I've changed the scanner to explicitly state "(no reason provided)" in this situation

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.94%. Comparing base (84f1a96) to head (0167354).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1241   +/-   ##
=======================================
  Coverage   67.94%   67.94%           
=======================================
  Files         174      174           
  Lines       16838    16848   +10     
=======================================
+ Hits        11440    11448    +8     
- Misses       4765     4766    +1     
- Partials      633      634    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cuixq cuixq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@G-Rath G-Rath force-pushed the no-trailing-space branch 2 times, most recently from 014fdd2 to 427d2ce Compare September 15, 2024 21:19
@another-rex another-rex merged commit 12eefba into google:main Sep 16, 2024
13 checks passed
@another-rex another-rex deleted the no-trailing-space branch September 16, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants