-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Adding CycloneDX 1.4 and 1.5 reporter #1014
✨ Adding CycloneDX 1.4 and 1.5 reporter #1014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you very much for contributing this! we'd love to support this feature in OSV-Scanner. I just have some comments.
…ered due to PURL malformation
… the grouper in the reporter instead 🚧 To be merged with be81d969
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I haven't had time to look into this recently, but I'll take a deeper look this week.
… it to Group to match conventions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, otherwise LGTM!
…CycloneDX_reporter
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
=======================================
Coverage ? 65.74%
=======================================
Files ? 159
Lines ? 12776
Branches ? 0
=======================================
Hits ? 8400
Misses ? 3905
Partials ? 471 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will aim to get this merged in next week.
About this PR
This PR aims to add the CycloneDX 1.4 and 1.5 format. The idea behind it is to be able to export everything in a commonly used format to later reuse the result to enrich it. (ex: re-running a vulnerability matching process on the packages to find emerging vulnerabilities).
This PR adds 2 versions of CycloneDX even though at the moment they report the exact same thing.
In future PR, we intend to extract where packages has been found during the extraction process (file, line, column), which is an information only supported by CycloneDX 1.5.
We need a CycloneDX 1.4 format for backward compatibility reasons.
Additional informations
You may want to review this PR commit by commit, as it should be easier to read