-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint readme #100
Lint readme #100
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I've attempted to add the GitHub email address (e.g. <number>+<username>@users.noreply.github.com) that is used to sign these commits, to my Google account, so that I can sign the CLA with that email address. Maintainers can chose either:
As you like 🙂 |
Thanks - personally I think it would be best to set CI up to check this, ideally with I can't speak for the CLA requirement, though I suspect it probably can't be wavered but again I'm happy to put my name against it if you're ok with that; alternatively I'm happy to handle the whole thing :) (sorry about closing, I fat-fingered the button 😅) |
Looks like the CLA is passing now! Thanks for contribution @wolf99. |
/gcbrun |
Becuase they've *alread* got lint issues since PR google#100
* Basic syntactical lint * Fix consoel code blocks Co-authored-by: Oliver Chang <[email protected]>
* Basic syntactical lint * Fix consoel code blocks Co-authored-by: Oliver Chang <[email protected]>
Hiya,
This PR lints the readme according to markdownlint rules.
If interested, I could add a further PR that adds a workflow that adds a markdown lint checker?