Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directory scanning should respect gitignore by default #165

Closed
another-rex opened this issue Jan 26, 2023 · 1 comment · Fixed by #191
Closed

directory scanning should respect gitignore by default #165

another-rex opened this issue Jan 26, 2023 · 1 comment · Fixed by #191
Assignees
@michaelkedar
Labels
enhancement New feature or request

Comments

@another-rex
Copy link
Collaborator

another-rex commented Jan 26, 2023 •
edited
Loading

OSV-scanner should respect the gitignore by default when walking directories and files.

A project might have a lot of deep directories (e.g. node_modules, build files...etc) that both slows down the scanner and produces a lot of noise. These directories are generally put in the .gitignore files, so ignoring them while scanning solves this by default.

A flag should be added to disable this .gitignore skipping.
@another-rex another-rex added the enhancement New feature or request label Jan 26, 2023
@michaelkedar michaelkedar self-assigned this Feb 6, 2023
@michaelkedar michaelkedar mentioned this issue Feb 7, 2023
Merged
michaelkedar added a commit that referenced this issue Feb 8, 2023
@michaelkedar
Make scanner respect .gitignore files (#191)
e4d2a02 
Closes #165 

Also changes `GetCommitSHA` to no longer rely on the system's git
executable.

By default, OSV-Scanner will skip files/directories that are ignored by
a git project's `.gitignore` files. Added a flag `--no-ignore` to
disable this behaviour.
cmaritan pushed a commit to cmaritan/osv-scanner that referenced this issue Feb 12, 2023
@michaelkedar @cmaritan
Make scanner respect .gitignore files (google#191)
1070553 
Closes google#165 

Also changes `GetCommitSHA` to no longer rely on the system's git
executable.

By default, OSV-Scanner will skip files/directories that are ignored by
a git project's `.gitignore` files. Added a flag `--no-ignore` to
disable this behaviour.
@another-rex
Copy link
Collaborator Author

another-rex commented Feb 14, 2023 •
edited
Loading

Implemented in #191

hayleycd pushed a commit that referenced this issue Mar 9, 2023
@michaelkedar @hayleycd
Make scanner respect .gitignore files (#191)
b43276d 
Closes #165 

Also changes `GetCommitSHA` to no longer rely on the system's git
executable.

By default, OSV-Scanner will skip files/directories that are ignored by
a git project's `.gitignore` files. Added a flag `--no-ignore` to
disable this behaviour.
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this issue May 2, 2023
@michaelkedar @julieqiu
Make scanner respect .gitignore files (google#191)
9d3c28f 
Closes google#165 

Also changes `GetCommitSHA` to no longer rely on the system's git
executable.

By default, OSV-Scanner will skip files/directories that are ignored by
a git project's `.gitignore` files. Added a flag `--no-ignore` to
disable this behaviour.
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this issue May 2, 2023
@michaelkedar @julieqiu
Make scanner respect .gitignore files (google#191)
8787969 
Closes google#165 

Also changes `GetCommitSHA` to no longer rely on the system's git
executable.

By default, OSV-Scanner will skip files/directories that are ignored by
a git project's `.gitignore` files. Added a flag `--no-ignore` to
disable this behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelkedar michaelkedar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make scanner respect .gitignore files michaelkedar/osv-scanner
2 participants
@michaelkedar @another-rex