Skip to content

Envoy: disable AFL engine#6891

Merged
asraa merged 1 commit intogoogle:masterfrom
adisuissa:envoy_disable_afl
Dec 13, 2021
Merged

Envoy: disable AFL engine#6891
asraa merged 1 commit intogoogle:masterfrom
adisuissa:envoy_disable_afl

Conversation

@adisuissa
Copy link
Contributor

Using AFL leads to out-of-space on the device.
Possible solution suggested in: bazel-contrib/rules_fuzzing#185

This PR disables AFL until we get this sorted out.

Signed-off-by: Adi Suissa-Peleg adip@google.com

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@jonathanmetzman
Copy link
Contributor

Is it only failing in CI?
I think we should simply blocklist the AFL build in CI or just ignore the failures. Deleting the build seems like the wrong solution IMO

@adisuissa
Copy link
Contributor Author

Is it only failing in CI? I think we should simply blocklist the AFL build in CI or just ignore the failures. Deleting the build seems like the wrong solution IMO

Thanks @jonathanmetzman for the input!

The failure is in the oss-fuzz build (non-CI).
One of the errors we've received is:

Step #3 - "compile-afl-address-x86_64": Execution platform: @local_config_platform//:host
Step #3 - "compile-afl-address-x86_64": tar: bazel-out/k8-fastbuild/bin/test/common/http/http2/response_header_fuzz_test_oss_fuzz.tar: Wrote only 4096 of 10240 bytes
Step #3 - "compile-afl-address-x86_64": tar: Error is not recoverable: exiting now
Step #3 - "compile-afl-address-x86_64": �[32mINFO: �[0mElapsed time: 5284.051s, Critical Path: 1350.00s

Other failures are less informative, and do not happen at the same place in the build process.
The build itself works on a local machine with enough disk space.
If there was a way to temporarily increase the docker disk space, we can easily validate that this is indeed the issue.

One of the alternatives is bazel-contrib/rules_fuzzing#185, but this:

  1. Does not guarantee to lower disk space usage below the current threshold.
  2. Will also require updating the rules_fuzzing, and possibly other updates.

@adisuissa
Copy link
Contributor Author

Some findings:
We've seen that the binary sizes when compiling with the AFL fuzzer are much larger.
For example:
AFL: -r-xr-xr-x 1 root root 1093254152 Dec 8 18:42 utility_fuzz_test
LIBFUZZER: -r-xr-xr-x 1 root root 115623224 Dec 9 15:42 utility_fuzz_test

The binary size with AFL is an order of magnitude larger.

Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine at least until there's an interim solution to why AFL binaries are so large

@asraa
Copy link
Contributor

asraa commented Dec 13, 2021

Going to merge in the interim until AFL is fixed.

@asraa asraa merged commit db74975 into google:master Dec 13, 2021
MartinPetkov pushed a commit to MartinPetkov/oss-fuzz that referenced this pull request Aug 15, 2022
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants