-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Gson setup #6833
Simplify Gson setup #6833
Conversation
$MVN --batch-mode --update-snapshots verify ${MAVEN_ARGS} | ||
MAVEN_ARGS="-DskipTests -Dmaven.compiler.release=8 -X" | ||
# Only build 'gson' Maven module | ||
cd gson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also alternatively run Maven for the parent project and only build the gson
module as described in https://stackoverflow.com/a/3899772, though this approach here works as well.
Do you prefer one solution over the other?
From the CI:
It looks like you're running into the same issue as I described here #6742 (comment) |
You are right sorry. Should be fixed now. Can you please run the CI workflows again? |
The build is now failing because for execution of ProGuard (which is part of the tests) the
I have disabled ProGuard execution now as well and at least locally when manually invoking Maven this configuration seems to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, thanks for simplifying this!
Tries to simplify the Gson setup as described in #6742 (comment).
I cannot easily verify that this works because I am using Windows, therefore I have marked this pull request as draft.