Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spuriously failing test #5218

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Fix spuriously failing test #5218

merged 1 commit into from
Feb 22, 2021

Conversation

jonathanmetzman
Copy link
Contributor

No description provided.

@jonathanmetzman
Copy link
Contributor Author

I think this issue is related to #5213

@inferno-chromium
Copy link
Collaborator

i dont understand this, will let @oliverchang review.

@jonathanmetzman
Copy link
Contributor Author

i dont understand this, will let @oliverchang review.

What don't you understand?
The test is really awful and depends on the real gonids project in OSS-Fuzz.
gonids is now broken because of an issue with go get.
I think we don't need to land this if go get issue is fixed soon.

@inferno-chromium
Copy link
Collaborator

i dont understand this, will let @oliverchang review.

What don't you understand?
The test is really awful and depends on the real gonids project in OSS-Fuzz.
gonids is now broken because of an issue with go get.
I think we don't need to land this if go get issue is fixed soon.

Why not remove gonids completely from

ExampleRepo(project_name='gonids',

or subsitute it with another repo. i see 2 already there, so can remove gonids completely too.

@inferno-chromium
Copy link
Collaborator

ping, infra-tests is breaking in every test, can you please check this in. might be best to just remove gonids altogether or add another go project.

@jonathanmetzman jonathanmetzman merged commit 1b0115e into master Feb 22, 2021
@jonathanmetzman jonathanmetzman deleted the failing-test branch February 22, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants