Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nodejs] Simplify build process as most work is now upstreamed. #4327

Merged
merged 3 commits into from
Aug 17, 2020
Merged

[nodejs] Simplify build process as most work is now upstreamed. #4327

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e48118
Build of nodejs has now been upstreamed and this commit simplifies th…
DavidKorczynski Aug 16, 2020
bfaafef
We only support libfuzzer for now.
DavidKorczynski Aug 16, 2020
b193d1f
Simplified the build script.
DavidKorczynski Aug 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions projects/nodejs/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,3 @@ RUN apt-get install -y flex bison build-essential
RUN git clone --recursive --depth 1 https://github.com/nodejs/node
WORKDIR $SRC
COPY build.sh $SRC/

COPY fuzz_url.cc $SRC/
25 changes: 2 additions & 23 deletions projects/nodejs/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,28 +19,7 @@ cd $SRC/node
# Build node
export LDFLAGS="$CXXFLAGS"
export LD="$CXX"
./configure --without-intl --without-node-code-cache --without-dtrace --without-snapshot --without-ssl
./configure --experimental-quic --with-ossfuzz
make -j$(nproc)

# Gather static libraries
cd $SRC/node/out
rm -rf ./library_files && mkdir library_files
find . -name "*.a" -exec cp {} ./library_files/ \;

# Build the fuzzers
CMDS="-D__STDC_FORMAT_MACROS -D__POSIX__ -DNODE_HAVE_I18N_SUPPORT=1 \
-DNODE_ARCH=\"x64\" -DNODE_PLATFORM=\"linux\" -DNODE_WANT_INTERNALS=1"
INCLUDES="-I../src -I../deps/v8/include -I../deps/uv/include"

# Compilation
$CXX -o fuzz_url.o $SRC/fuzz_url.cc $CXXFLAGS $CMDS $INCLUDES \
-pthread -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -c

# Linking
$CXX -o $OUT/fuzz_url $LIB_FUZZING_ENGINE $CXXFLAGS \
-rdynamic -Wl,-z,noexecstack,-z,relro,-z,now \
-pthread -Wl,--start-group \
./Release/obj.target/cctest/src/node_snapshot_stub.o \
./Release/obj.target/cctest/src/node_code_cache_stub.o \
fuzz_url.o ./library_files/*.a \
-latomic -lm -ldl -Wl,--end-group
cp /src/node/out/Release/fuzz_url ${OUT}/
DavidKorczynski marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 2 additions & 0 deletions projects/nodejs/project.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
homepage: "https://nodejs.org"
primary_contact: "[email protected]"
language: c++
fuzzing_engines:
- libfuzzer
sanitizers:
- address
auto_ccs:
Expand Down