Skip to content

envoy: blacklist some problematic external dep UBSAN. #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inferno-chromium merged 1 commit into from
Mar 19, 2019
Merged

envoy: blacklist some problematic external dep UBSAN. #2242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions projects/envoy/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,15 @@ do
fi
done

# Override sanitizers, useful for non-Envoy code that we're trying to fix and
# that is acting as a build blockers.
declare -r BLACKLIST_PATH=blacklist.txt
cat <<EOF > "${BLACKLIST_PATH}"
# TODO(htuch): remove when we
# havehttps://github.com/protocolbuffers/protobuf/pull/5901.
fun:*FastInt64ToBufferLeft*
EOF

# Build driverless libraries.
# TODO(htuch): Remove the CC/CXX/CFLAGS/CXXFLAGS passing, this is only there for
# cmake_external limitation in understanding --cxxopt etc., it should not be
Expand All @@ -73,6 +82,7 @@ done
bazel build --verbose_failures --dynamic_mode=off --spawn_strategy=standalone \
--genrule_strategy=standalone --strip=never \
--copt=-fno-sanitize=vptr --linkopt=-fno-sanitize=vptr --linkopt=-lc++fs \
--copt=-fsanitize-blacklist="${BLACKLIST_PATH}" \
--define tcmalloc=disabled --define signal_trace=disabled \
--define ENVOY_CONFIG_ASAN=1 --copt -D__SANITIZE_ADDRESS__ \
--define force_libcpp=enabled \
Expand Down