fix(base-images): Ensure 'latest' tag is pushed for legacy images #14140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'latest' tag was being applied to legacy images during the build process but was not included in the list of images to be pushed to the container registry. This change ensures that the 'latest' tag is explicitly added to the push list for the 'legacy' version, restoring the intended behavior.
hunsche
changed the title
|
/gcbrun trial_build.py zlib bad_example --fuzzing-engines libfuzzer --sanitizers address |
|
/gcbrun trial_build.py zlib bad_example --fuzzing-engines libfuzzer --sanitizers address |
|
/gcbrun trial_build.py zlib bad_example --fuzzing-engines libfuzzer --sanitizers address |
vitaliset
approved these changes
Oct 16, 2025
hunsche
deleted the
revert-14138-revert-14112-feat/parallel-base-image-builds
branch
oliverchang
added a commit
that referenced
this pull request
Oct 19, 2025
The return type of `build_lib.run_build` was changed, without changing
all the callers. In particular, `build_project.run_build` was expected
to still return an ID.
```
> git grep build_project.run_build
infra/build/functions/project_experiment.py: return build_project.run_build(project_name,
infra/build/functions/request_build.py: build_id = build_project.run_build(oss_fuzz_project, build_steps, credentials,
infra/build/functions/target_experiment.py: build_id = build_project.run_build(
infra/build/functions/trial_build.py: build_ids[project_name] = (build_project.run_build(
infra/build/functions/trial_build_test.py: @mock.patch('build_project.run_build')
```
Fixes #14153
oliverchang
added a commit
that referenced
this pull request
Oct 20, 2025
The return type of `build_lib.run_build` was changed, without changing
all the callers. In particular, `build_project.run_build` was expected
to still return an ID.
```
> git grep build_project.run_build
infra/build/functions/project_experiment.py: return build_project.run_build(project_name,
infra/build/functions/request_build.py: build_id = build_project.run_build(oss_fuzz_project, build_steps, credentials,
infra/build/functions/target_experiment.py: build_id = build_project.run_build(
infra/build/functions/trial_build.py: build_ids[project_name] = (build_project.run_build(
infra/build/functions/trial_build_test.py: @mock.patch('build_project.run_build')
```
Fixes #14153
hunsche
added a commit
that referenced
this pull request
Oct 20, 2025
hunsche
added a commit
that referenced
this pull request
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an issue where the
:latesttag forlegacybase images was being applied during the build but was not being pushed to the container registry.The previous logic correctly added the
latesttag during the image build step, but this tag was omitted from the final list of images sent to Google Cloud Build for pushing.This change updates the
base_builderfunction to explicitly add the:latesttagged images to the push list when the build version islegacy, ensuring they are available in the registry as intended.Verification
The fix was verified by running a manual build and confirming the outcome.
1. Successful Cloud Builds:
2. GCR Tag Verification:
The
gcr.io/oss-fuzz-base/base-builderimage tags were inspected to confirm they were pushed by the builds above. The timestamps confirm the successful push of all tags, includinglatestfor the legacy build.