Skip to content

Temporary fix for imagemagick and xpdf: harfbuzz dynamic loading #13325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanmetzman merged 2 commits into from
May 16, 2025
Merged

Temporary fix for imagemagick and xpdf: harfbuzz dynamic loading #13325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01f8057
Temporary fix for imagemagick and xpdf: harfbuzz dynamic loading
jonathanmetzman May 15, 2025
4e7580a
Comment
jonathanmetzman May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions projects/imagemagick/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,10 @@
#
################################################################################

# Temporarily Add -D_GNU_SOURCE to CFLAGS to fix freetype's dependence on GNU
# extensions for dlsym to dynamically load harfbuzz. This feature
# should potentially be disabled instead of fixing the compilation. But that is
# not possible to do from the OSS-Fuzz repo :-)
# See https://github.com/google/oss-fuzz/pull/13325 for more details.
export CFLAGS="$CFLAGS -D_GNU_SOURCE"
. oss-fuzz/build.sh
12 changes: 8 additions & 4 deletions projects/xpdf/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,14 @@ export PKG_CONFIG="`which pkg-config` --static"
export PKG_CONFIG_PATH=$PREFIX/lib/pkgconfig
export PATH=$PREFIX/bin:$PATH
pushd $SRC/freetype
./autogen.sh
./configure --prefix="$PREFIX" --disable-shared PKG_CONFIG_PATH="$PKG_CONFIG_PATH" --with-png=no --with-zlib=no
make -j$(nproc)
make install
# Temporarily Add -D_GNU_SOURCE to CFLAGS to fix freetype's dependence on GNU
# extensions for dlsym to dynamically load harfbuzz. This feature
# should potentially be disabled instead of fixing the compilation.
# See https://github.com/google/oss-fuzz/pull/13325 for more details.
CFLAGS="$CFLAGS -D_GNU_SOURCE" ./autogen.sh
CFLAGS="$CFLAGS -D_GNU_SOURCE" ./configure --prefix="$PREFIX" --disable-shared PKG_CONFIG_PATH="$PKG_CONFIG_PATH" --with-png=no --with-zlib=no
CFLAGS="$CFLAGS -D_GNU_SOURCE" make -j$(nproc)
CFLAGS="$CFLAGS -D_GNU_SOURCE" make install
popd

# Make minor change in the CMakeFiles file.
Expand Down
Loading