Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-fixer: extend for ConsumeBytes #652

Merged
merged 9 commits into from
Oct 2, 2024
Merged

code-fixer: extend for ConsumeBytes #652

merged 9 commits into from
Oct 2, 2024

Conversation

DavidKorczynski
Copy link
Collaborator

Ref: #575
Ref: #301

@DavidKorczynski
Copy link
Collaborator Author

/gcbrun exp -n d-cov-50 -b bug-fdp-consume-buffers -ns 4 -rd

Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

/gcbrun exp -n d-cov-51 -b bug-fdp-consume-buffers -ns 8 -rd

Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

/gcbrun exp -n d-cov-251 -b bug-fdp-consume-buffers -ns 4 -rd

@DavidKorczynski
Copy link
Collaborator Author

/gcbrun exp -n d-cov-254 -b bug-fdp-consume-buffers -ns 4 -rd

@DavidKorczynski DavidKorczynski marked this pull request as ready for review October 1, 2024 20:06
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

/gcbrun exp -n d-cov-255 -b bug-fdp-consume-buffers -ns 4 -rd

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

@DavidKorczynski DavidKorczynski marked this pull request as draft October 1, 2024 21:19
@DavidKorczynski
Copy link
Collaborator Author

/gcbrun exp -n d-cov-256 -b bug-fdp-consume-buffers -ns 4 -rd

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski DavidKorczynski marked this pull request as ready for review October 2, 2024 08:21
@AdamKorcz AdamKorcz merged commit 78f04b6 into main Oct 2, 2024
6 checks passed
@AdamKorcz AdamKorcz deleted the extend-fixer-logic branch October 2, 2024 08:25
f'Furthermore, consider changing {buffer_method} to '
'`ConsumeRandomLengthString` for creating `char` buffers or strings. '
'In most cases, `ConsumeRandomLengthString` is preferred, and '
f'should be used instead of {buffer_method}\n')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Do we need two instructions if the source code contains both ConsumeBytes and ConsumeData?
As an alternative to shorten the prompt, we can merge them to

IMPORTANT: the harness source code contains a call to `ConsumeBytes ` or `ConsumeBytes`. ...

if the code contains either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants