-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code-fixer: extend for ConsumeBytes #652
Conversation
/gcbrun exp -n d-cov-50 -b bug-fdp-consume-buffers -ns 4 -rd |
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
/gcbrun exp -n d-cov-51 -b bug-fdp-consume-buffers -ns 8 -rd |
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
/gcbrun exp -n d-cov-251 -b bug-fdp-consume-buffers -ns 4 -rd |
/gcbrun exp -n d-cov-254 -b bug-fdp-consume-buffers -ns 4 -rd |
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
/gcbrun exp -n d-cov-255 -b bug-fdp-consume-buffers -ns 4 -rd |
Signed-off-by: David Korczynski <[email protected]>
The most recent commit made it worse than before: https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2024-10-02-652-d-cov-255-bug-fdp-consume-buffers/index.html |
/gcbrun exp -n d-cov-256 -b bug-fdp-consume-buffers -ns 4 -rd |
Signed-off-by: David Korczynski <[email protected]>
The current one works in cases:
But is no silver bullet: This should be good to go at this point -- my take is that it should have positive impact on the next larger runs and reduce FPs |
f'Furthermore, consider changing {buffer_method} to ' | ||
'`ConsumeRandomLengthString` for creating `char` buffers or strings. ' | ||
'In most cases, `ConsumeRandomLengthString` is preferred, and ' | ||
f'should be used instead of {buffer_method}\n') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Do we need two instructions if the source code contains both ConsumeBytes
and ConsumeData
?
As an alternative to shorten the prompt, we can merge them to
IMPORTANT: the harness source code contains a call to `ConsumeBytes ` or `ConsumeBytes`. ...
if the code contains either.
Ref: #575
Ref: #301