Refactor GCS Operations to Use TensorFlow's File System #2426
+45
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR decouples Orbax from direct GCS API dependencies by delegating all filesystem operations to the underlying TensorFlow gfile implementation. This change improves testability and makes Orbax less susceptible to regressions from GCS client changes.
Key Changes:
Dependency Removal: All direct GCS API calls have been removed from Orbax and are now handled by TensorFlow's GCS filesystem.
HNS Checkpoint Renaming: Orbax now implicitly supports fast checkpoint renames on HNS-enabled buckets. Users can enable this feature by configuring _todelete_full_path, which triggers a tf.io.gfile.rename call. The underlying library handles HNS detection automatically.
Simplified Listing Logic: The custom logic for includeFoldersAsPrefixes has been removed, as this is now handled by default in TensorFlow's listdir implementation.